francoispqt / gojay

high performance JSON encoder/decoder with stream API for Golang
MIT License
2.11k stars 112 forks source link

MsgPack benchmarks #45

Closed matfax closed 6 years ago

matfax commented 6 years ago

I think it would be fair and transparent to add benchmark results for msgpack v2.

Contrasting gojay to msgpack, it becomes clear that gojay clearly has its advantages for small and linear structures, but is outperformed with large ones.

codecov-io commented 6 years ago

Codecov Report

Merging #45 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          30     30           
  Lines        3529   3529           
=====================================
  Hits         3529   3529

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f324ba0...4a2aa39. Read the comment docs.

francoispqt commented 6 years ago

Hi, thanks for the suggestion.

MessagePack is not pure JSON. MessagePack JSON can only be decoded by a MessagePack decoder, in fact MesagePack has its own specification.

Let's compare apple with apples, otherwise we will start comparing CBOR, BSON, MessagePack and JSON all together when they actually are different formats. But writing a MessagePack implementation using what we learn from writing GoJay would be interesting.