Code generation tool should fail if it can't generate code for any fields

francoispqt / gojay

high performance JSON encoder/decoder with stream API for Golang

MIT License

2.11k stars 112 forks source link

Code generation tool should fail if it can't generate code for any fields #52

Closed veqryn closed 5 years ago

veqryn commented 6 years ago

I ran the code generation tool against some of my structs, and discovered that it was missing several fields in the generated code. The fields that were missing were Slices.

Yes, your documentation says those aren't supported. But your code generation tool needs to at least output an error message for each non-supported public/exported field so that people don't assume everything is good.

francoispqt commented 5 years ago

The new generator does that. I'm closing this one.