search

francoispqt / gojay

high performance JSON encoder/decoder with stream API for Golang
MIT License
2.11k stars 112 forks source link

Adds DecodeInterface for interface decoding #64

Closed afiune closed 6 years ago

afiune commented 6 years ago

Temporal solution to the unmarshaling of interfaces{} in Go

Closes https://github.com/francoispqt/gojay/issues/62

Signed-off-by: Salim Afiune afiune@chef.io

codecov-io commented 6 years ago

Codecov Report

Merging #64 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   99.95%   99.95%   +<.01%     
==========================================
  Files          35       36       +1     
  Lines        4075     4164      +89     
==========================================
+ Hits         4073     4162      +89     
  Misses          1        1              
  Partials        1        1
Impacted Files Coverage Δ
decode.go 100% <100%> (ø) :arrow_up:
decode_interface.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a506888...6161f8d. Read the comment docs.

afiune commented 6 years ago

I will add more tests in a few. 😅

francoispqt commented 6 years ago

Let me review this :)

francoispqt commented 6 years ago

It seems good to me. Regarding your question about returning the type from the getObject method, I think we don't really need. I'm rebasing it from master and will merge it.

Thanks!