Added advanced code generation

francoispqt / gojay

high performance JSON encoder/decoder with stream API for Golang

MIT License

2.11k stars 112 forks source link

Added advanced code generation #75

Closed adranwit closed 5 years ago

adranwit commented 5 years ago

dependent type included in the generated code
- embedded type support
- referring type support (i.e type Payload []byte)
- option to generate code reusing object with sync.Pool
- custom annotation tag support, i.e "json:"key1" vs gojay:"key1"
- time formatting support

francoispqt commented 5 years ago

Sorry didn't have much type these past few days. Will check that today and tomorrow.

matfax commented 5 years ago

Interesting project @adranwit. Have you considered publishing it under a separate repository?

adranwit commented 5 years ago

Waiting for @francoispqt to either reject it or accept, the code generation uses based classes provided by this project, so I believe this is a good place for it.

francoispqt commented 5 years ago

Sorry for the delay to review the PR. It’s been hanging out here way too long. I’m reviewing/testing it right now.

francoispqt commented 5 years ago

So there are nice things. Overall the design is better than the original codegen tool. I like also the possibility to pool objects.

I'm removing the binary in the PR, fixed the bug for stdout output, update dep files and will merge to master.

I will let both gen tools live here for now but will replace the old one with this one after:

add support for a bunch of types that were added like sql.NullXxx
add support for omitempty and nullempty

Thank you