search

francoispqt / gojay

high performance JSON encoder/decoder with stream API for Golang
MIT License
2.11k stars 112 forks source link

Fixed incorrect unmarshalling of numbers in scientific format in several cases #90

Closed susuper closed 5 years ago

susuper commented 5 years ago

Hello. The current version can't unmarshal numbers in scientific notation in several cases. Attached is an example of error.

example.zip

codecov-io commented 5 years ago

Codecov Report

Merging #90 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          36       36           
  Lines        5161     5161           
=======================================
  Hits         5096     5096           
  Misses         51       51           
  Partials       14       14
Impacted Files Coverage Δ
decode_number.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ebfcfb...60a9239. Read the comment docs.

francoispqt commented 5 years ago

Hi, thanks for the PR. I'll review it today.