Closed OGKevin closed 5 years ago
Merging #98 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #98 +/- ##
======================================
Coverage 98.7% 98.7%
======================================
Files 36 36
Lines 5189 5189
======================================
Hits 5122 5122
Misses 52 52
Partials 15 15
Impacted Files | Coverage Δ | |
---|---|---|
encode_stream.go | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 90d9533...92f89c6. Read the comment docs.
hey @francoispqt whats the status on this PR?
Fixes #97
By using the writer lock, you ensure that close is called only once. Closing the chan should be seen as a write operation and not a read operation.
By using the read lock, there is a possibility that concurrent calls to cancel will cause a panic. Using a write lock fixes this.