search

francoisromain / leaflet-markers-canvas

A Leaflet plugin to render many markers in a canvas instead of the DOM
GNU Affero General Public License v3.0
42 stars 15 forks source link

removeMarker works very slowly when removing a lot of markers #6

Closed benderlidze closed 2 years ago

benderlidze commented 2 years ago

Thank you for your lib, it is great. addMarkers is fast, is it possible to add something like removeMarkerS since removeMarker is slow when trying to delete 10k markers by one As I find out this part makes it slow

 if (isVisible) {
          this._redraw(true);
        }

Thanks

francoisromain commented 2 years ago

Hello there is already a clear function to remove all the markers. Does it work for your case?

benderlidze commented 2 years ago

I need to remove a part of markers, for example, 10k from 20k or so. I don't want to remove all markers

francoisromain commented 2 years ago

I made something in the PR above but I didn't try. Could you see if it works please?

benderlidze commented 2 years ago

Yes, this works fine for me. Thank you!