search

francostellari / NppPlugins

Other
111 stars 7 forks source link

[Menu Icons] Strip/replace double quotes (") from filenames #46

Closed jmaraujouy closed 1 year ago

jmaraujouy commented 1 year ago

Hello, Franco.

I have noticed that there are some menu entries that contains double quotes (") in their name.

The thing is, Menu Icons is not stripping the double quotes (") from the expected icon filename, which makes impossible to assign them an icon, since double quotes are reserved characters and cannot be used in filenames.

Just to give you an example, the plugin Code Alignment has a menu item with the name «Align by quote (")». If I generate a list from Menu Icons config, the suggested filename is: Align by quote (").ico, which is impossible to name the file.

imagen

I know some characters are being stripped or replaced with a number/pound sign (#), but this is not the case with the double quotes. I haven't tested with any other reserved characters: < > : / \ | ? *.

Can this be fixed in a future release?

Thanks!

PS: And thank you so much for the plugin, which makes Notepad++ a lot more enjoyable to use. 😉

jmaraujouy commented 1 year ago

I know some characters are being stripped or replaced with a number/pound sign (#), but this is not the case with the double quotes. I haven't tested with any other reserved characters: < > : / \ | ? *.

I can confirm it also happens with the 'greater-than' character.

imagen

Generated list: ASCII -> HEX 22036 ==> d:\MenuIcons\Complementos\Converter\ASCII -> HEX.ico HEX -> ASCII 22037 ==> d:\MenuIcons\Complementos\Converter\HEX -> ASCII.ico

francostellari commented 1 year ago

I will add the character stripping in the next release... when I have time.

jmaraujouy commented 1 year ago

@francostellari Great! Thank you.

francostellari commented 1 year ago

@jmaraujouy please manually test the new v2.0.3. It should solve your problems https://github.com/francostellari/NppPlugins/blob/main/MenuIcons/MenuIcons_dll_2v03_x64.zip

jmaraujouy commented 1 year ago

@francostellari Hi, Franco. Thanks for the quick fix. I can confirm this issue is solved. 👍🏻👍🏻

imagen

Thank you!

PS: As you can see in the screenshot, I made a new icon set using Microsoft's Fluent UI icons.

I made icons for every menu/submenu/context menu. I just need to make a new set for npp light theme (which is the fastest and easier part; all that is needed is to invert each image 😉).

As soon as it is done I can post them here. Let me know if you're interested.