search

francostellari / NppPlugins

Other
105 stars 6 forks source link

[Menu Icons] Regression: Strip ... in German locale does't work any more #54

Closed bege10 closed 10 months ago

bege10 commented 11 months ago

Hello, there is a regression in 2v03 and 2v04. With option plain text match all entries with ... with German locale have no icons any more. This had been fixed in #10.

bege10 commented 11 months ago

@francostellari Can you, please, fix this regression? Thanks!

francostellari commented 11 months ago

@bege10 I cannot see or reproduce your problem. I switched to German. I'm targeting File/Open... in German:

&Öffnen ?   41002   ==> C:\scoop\apps\notepadplusplus\current\Plugins\MenuIcons\EN-US\Datei\Öffnen.ico

I created an icon with the pecified path image The Icon shows in the menu: image

bege10 commented 11 months ago

With these settings Screenshot_341 with 2v02 I have this Screenshot_339 and with 2v03 or v04 I have this Screenshot_340

francostellari commented 11 months ago

Perhaps the expected file path is different. You need to use Generate List and make sure that whatever version you use the filenames match the expected values.

bege10 commented 11 months ago

Perhaps the expected file path is different. You need to use Generate List and make sure that whatever version you use the filenames match the expected values.

This is the same NPP version, I only change the MenuIcons.dll in the C:\Program Files\Notepad++\plugins\MenuIcons folder and restart NPP.

2v02: &Öffnen ? 41002 ==> C:\Program Files\Notepad++\Plugins\MenuIcons\DE\Datei\Öffnen.ico 2v03: &Öffnen ? 41002 ==> C:\Program Files\Notepad++\Plugins\MenuIcons\DE\Datei\Öffnen ?.ico

The ? we know already from #10

francostellari commented 11 months ago

@bege10 I believe v2.05 should fix this issue

bege10 commented 10 months ago

@bege10 I believe v2.05 should fix this issue

Yep, thank you very much! v2.05 is not in the NPP updater yet. (Still v2.03)