frandallfarmer / neohabitat

Repository for the NeoClassical Habitat Server Project
http://neohabitat.org
MIT License
230 stars 42 forks source link

Fixes noids for Region.java #302

Closed TheCarlSaganExpress closed 6 years ago

TheCarlSaganExpress commented 6 years ago

All regions should now have 0 as their noid. Well, technically they already did, but this time it's explicit.

Before: "type":"context","ref":"context-Downtown_5f","name":"Plaza Fountain","mods":[{"type":"Region","orientation":0,"nitty_bits":3,"depth":32,"lighting":0,"neighbors":["context-Downtown_5g","context-Downtown_6f","context-Downtown_5e","context-Downtown_4f"]}]}}

After: "type":"context","ref":"context-Downtown_5f","name":"Plaza Fountain","mods":[{"type":"Region","orientation":0,"nitty_bits":3,"depth":32,"lighting":0,"noid":0,"neighbors":["context-Downtown_5g","context-Downtown_6f","context-Downtown_5e","context-Downtown_4f"]}]}}

frandallfarmer commented 6 years ago

Why did you do this? It is NOT valid to pass noid to the region constructor. It must always be 0, so we don't pass it. Do not pass arguments that aren't allowed to vary.