frandallfarmer / neohabitat

Repository for the NeoClassical Habitat Server Project
http://neohabitat.org
MIT License
228 stars 42 forks source link

F7 for Street turfs output looks wrong #375

Open StuBlad opened 3 years ago

StuBlad commented 3 years ago

image

F7 on your avatar formats the output wrong for the turf if your turf is a street/home.

As you can see in this screenshot, it says:

"You live at OutamyWy 529 #interior."

It would look much better as:

"You live at 529 Outtamy Wy."

F7 inside the street/home turf itself displays the regions name which is formatted as "number street name" or "529 Outtamy Wy".

Would there be a way to add in a case where if the turf context of the avatar doesn't say Popustop, to just use the home regions name instead of the context file name?

frandallfarmer commented 3 years ago

The name of the region is the name of the region. What were the original names? Is the help text the same as it was then? It should match what it was in 1986. If it does, this issue will be marked as "As Designed", if there is a mispatch, we should fix the region names to match their 1986 text.

frandallfarmer commented 3 years ago

Note: Even if we change the names, they won't get changed on the server until the next database reset.

StuBlad commented 3 years ago

The name of the region matches the database backup fine. It's just, we parse turf names for displaying when you F7 on yourself in a particular way. We don't just pass the region name along when you F7, but instead we take the context name (seperate from the region name) and massage it to look good. That's fine for Popustop regions, but not for Street/Homes.