search

frandiox / vite-ssr

Use Vite for server side rendering in Node
MIT License
823 stars 91 forks source link

feat: add support for @vueuse/head versions >1.0.0 #196

Open ManneW opened 1 year ago

ManneW commented 1 year ago

The purpose of the changes in this PR is to add support for the consumer of the library to use newer versions of the @vueuse/head library, while still retaining compatibility with lower versions.

To have reliable test cases to ensure both versions are working, the structure of how the test fixtures are provided access to the vite-ssr build is slightly modified.

Feel free to ask any questions or add feedback about the implementation and I'll be happy to assist.

thomasowow commented 1 year ago

Fixes #195

ManneW commented 1 year ago

I think this also fixes #194 :slightly_smiling_face:

SuzanaK commented 1 year ago

Any idea when this can be merged?

phlegx commented 1 year ago

@frandiox the package @vueuse/head gets deprecated in the coming months.

See here: vueuse/head

In the coming months, the @vueuse/head package will be deprecated. If you're setting up this package on a new project, you should use the @unhead/vue package directly.

frandiox commented 1 year ago

Thanks a lot for this PR, and sorry for the late response! Not sure if we need backwards compatibility for 0.x or we can just require 1.x (or better, @unhead/vue) 🤔 Will try to come back to this in the weekend 🙏

thomasowow commented 1 year ago

Thanks a lot for this PR, and sorry for the late response! Not sure if we need backwards compatibility for 0.x or we can just require 1.x (or better, @unhead/vue) thinking Will try to come back to this in the weekend pray

Make sure to undo/update the change from #195 before this PR is merged.

phlegx commented 1 year ago

@frandiox thank you so much! If dependencies like @unhead/vue are upgraded, we should also upgrade @rollup/plugin-replace to v5.x. Like described in #201 warnings related to @rollup/plugin-replace can be solved.

phlegx commented 1 year ago

Hi! News from here? I can help to test the new planned version.