fix: Concurrency race when running in parallel

franela / goblin

Minimal and Beautiful Go testing framework

MIT License

884 stars 79 forks source link

Closed xpzouying closed 3 years ago

xpzouying commented 3 years ago

Use sync.Once to init flag variables.

fix: #98 #99

marcosnils commented 3 years ago

Thanks for the contribution. I see that tests are failing on CI.

xpzouying commented 3 years ago

The upstream branch couldn't pass the test. The error was not introduced by this PR.

Please check the current unit tests.

Thank you.

marcosnils commented 3 years ago

master branch tests are currently green https://github.com/franela/goblin/runs/1215884598. Re-check on your side please.

xpzouying commented 3 years ago

@marcosnils fix it.

Please code review.

Thank you.

close #98 #99

marcosnils commented 3 years ago

LGTM!