search

franela / goblin

Minimal and Beautiful Go testing framework
MIT License
887 stars 79 forks source link

Timeout support. #30

Closed marcosnils closed 10 years ago

xetorthio commented 11 years ago

I think we should add a flag to the go test command. Maybe something like:

go test -goblin.timeout 100ms

It makes more sense than defining it on every test file. What do you think?

marcosnils commented 11 years ago

Sounds like a good idea.

I'll add it and update the pr as needed

sent from mobile El nov 14, 2013 3:49 p.m., "Jonathan Leibiusky" notifications@github.com escribió:

I think we should add a flag to the go test command. Maybe something like:

go test -goblin.timeout 100ms

It makes more sense than defining it on every test file. What do you think?

— Reply to this email directly or view it on GitHubhttps://github.com/franela/goblin/pull/30#issuecomment-28511088 .

marcosnils commented 10 years ago

Finally it's done.

You can provide a timeout either through the command line like go test -goblin.timeout=5s or you can initialize goblin programatically like Goblin(t, "-goblin.timeout=5s")

xetorthio commented 10 years ago

Amazing job! :)