search

franela / goblin

Minimal and Beautiful Go testing framework
MIT License
883 stars 79 forks source link

Check type equality in assert equals #39

Closed kevin-cantwell closed 9 years ago

kevin-cantwell commented 10 years ago

Small bug in that type aliases don't get validated in reflect.DeepEquals and may therefore pass an Equals assertion.

marcosnils commented 10 years ago

@kevin-cantwell thanks for the bugfixing. Any chance you can run the code through gofmt to apply the proper indentation?. PR shows some lines are not correctly indented.

Thx!.

apriendeau commented 9 years ago

@marcosnils could we merge this please?

marcosnils commented 9 years ago

@apriendeau a totally forgot about this. Its merged now

apriendeau commented 9 years ago

Thanks :)