Closed criloz closed 4 years ago
Example:
package foobar
import (
"testing"
. "github.com/franela/goblin"
"github.com/stretchr/testify/assert"
)
func Test(t *testing.T) {
g := Goblin(t)
g.Describe("lala", func() {
g.It("lslslslsls", func() {
assert.Equal(g, 1, 10)
})
})
}
You're adding code that's not tested :S
@marcosnils can you tell where do you test your Fail
function?, I try to look in the code but for my time schedule I could not find the test case, the Errorf
function is almost the same, with the adition that allow format strings
@marcosnils can you tell where do you test your Fail function?, I try to look in the code but for my time schedule I could not find the test case, the Errorf function is almost the same, with the adition that allow format strings
I get it, but we can't add code without tests as someone will have to support this in the future. Here's how we test the Fail func:
@criloz Fail
and Failf
have almost the same code. Can you please extract the common parts function so we don't have duplicated code?
@marcosnils sure, will work on that tomorrow. also update the readme with the testify support example
Amazing!. Thx a lot!. We're almost there :D
Is this feature complete?
What happened to this?
@alexdreptu seems like it never got completed and got abandoned.
@marcosnils as I can see, it is completed! No duplicated code) May be it is ok to merge it?)
I've checked it locally — works perfectly!)
I created #85 and fixed the 2016 issue with this pr
Closed by #85
add support to https://github.com/stretchr/testify implements Errorf function