search

franela / goblin

Minimal and Beautiful Go testing framework
MIT License
884 stars 79 forks source link

Request: Move Hosting of Images #61

Open dan9186 opened 7 years ago

dan9186 commented 7 years ago

I'd first like to say thanks for all the efforts and time spent putting together such a useful project.

I use Goblin in almost every single Go project I ever write, and have noticed every time that I vendor my projects there is always the Goblin logo somewhere in that PR. It finally lead me to general curiosity of wondering how many instances of the goblin_logo.jpg and goblin_output.png are in my stuff.

I see that you've done a great job of reducing the size of those files, however it eventually add up. A look across my system right now with find $GOPATH/src -name "goblin_output.png" | wc -l says 78 of each. Napkin math says thats 4,251 KB of images vendored on my system right now.

If you were to move the images to a Github Pages repo like franela.github.io/goblin/images, and link it here that would be an easy win to remove the needless duplication of those images as Goblin is vendored across the Go landscape. All in all, I understand it's not terribly important and you may not wish to bother taking the time. I only wanted to point it out as a possibility to consider.

xetorthio commented 7 years ago

Totally agree! We'll do it!

On Sun, Aug 20, 2017, 16:53 Daniel Hess notifications@github.com wrote:

I'd first like to say thanks for all the efforts and time spent putting together such a useful project.

I use Goblin in almost every single Go project I ever write, and have noticed every time that I vendor my projects there is always the Goblin logo somewhere in that PR. It finally lead me to general curiosity of wondering how many instances of the goblin_logo.jpg and goblin_output.png are in my stuff.

I see that you've done a great job of reducing the size of those files, however it eventually add up. A look across my system right now with find $GOPATH/src -name "goblin_output.png" | wc -l says 78 of each. Napkin math says thats 4,251 KB of images vendored on my system right now.

If you were to move the images to a Github Pages repo like franela.github.io/goblin/images, and link it here that would be an easy win to remove the needless duplication of those images as Goblin is vendored across the Go landscape. All in all, I understand it's not terribly important and you may not wish to bother taking the time. I only wanted to point it out as a possibility to consider.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/franela/goblin/issues/61, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIhp8PZ966jpCUjCkk_YqYpYU9coDyXks5saI6dgaJpZM4O8thT .

marcosnils commented 7 years ago

Makes totally sense. We'll move the images somewhere else.