franela / goblin

Minimal and Beautiful Go testing framework
MIT License
883 stars 79 forks source link

Feature Request: Xit() to Exclude Test #62

Closed dan9186 closed 6 years ago

dan9186 commented 6 years ago

I saw issue #56 has been around for a while with the comment of not having time to add it, and noticed #60 came up recently. Thought I would take a stab at adding it.

dan9186 commented 6 years ago

Good idea. Added an extra check for making sure count is not altered.

marcosnils commented 6 years ago

Thanks a lot for the contribution @dan9186 . We'll move the images to static hosting soon :)

jayd3e commented 6 years ago

Why was Xit chosen instead of something like Ignore, @dan9186? It strikes me as far less clear.

dan9186 commented 6 years ago

With a conversation already existing where the project owner expressed acceptance of Xit and the project's goal of matching behavior to Mocha, I opted for what seemed to be most inline with those two points.

jayd3e commented 6 years ago

Those reasons make sense! Thanks for the explanation. Already using this feature 👌 . Thanks!