franglais125 / apt-update-indicator

Apt Update Indicator
https://extensions.gnome.org/extension/1139/apt-update-indicator/
GNU General Public License v3.0
44 stars 17 forks source link

Resize if no count shown #10

Closed ghost closed 7 years ago

ghost commented 7 years ago

When no count is shown on the panel, this applet leaves empty space, which typically isn't nice-looking. Please resize the applet when no count is given. Also, the applet seems to be a little lower than other applets. Perhaps it's smaller and has been resized down?

franglais125 commented 7 years ago

Thanks for reporting this.

1) I'll try to see if I can easily remove the empty space you mention.

2) The applet is not really lower, the thing is the icon itself has extra blank space at the top. This makes it look small and off the center. You can have a look at it here: /usr/share/icons/Adwaita/scalable/apps/system-software-install-symbolic/svg. Issue #8 is similar.

ghost commented 7 years ago

I'm using a custom-made icon theme, and I can change the icon. Thank you!

On Tue, Apr 18, 2017, 4:56 PM Fran Glais notifications@github.com wrote:

Thanks for reporting this.

1.

I'll try to see if I can easily remove the empty space you mention. 2.

The applet is not really lower, the thing is the icon itself has extra blank space at the top. This makes it look small and off the center. You can have a look at it here: /usr/share/icons/Adwaita/scalable/apps/system-software-install-symbolic/svg. Issue #8 https://github.com/franglais125/apt-update-indicator/issues/8 is similar.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/franglais125/apt-update-indicator/issues/10#issuecomment-294890419, or mute the thread https://github.com/notifications/unsubscribe-auth/ARILTnHcZPvkg3Q-ojms4iH2Set_4htoks5rxN01gaJpZM4NAaNi .

--

AK

franglais125 commented 7 years ago

Hi, I think I fixed this in the master branch. Can you give it a try?

Also, wrt the icon size, can you post a screenshot? Just to make sure you don't see anything different to what I have.

Here is what my icons look like: screenshot from 2017-04-19 16-16-50

ghost commented 7 years ago

Yup. It works out now. Thank you!