search

franglais125 / apt-update-indicator

Apt Update Indicator
https://extensions.gnome.org/extension/1139/apt-update-indicator/
GNU General Public License v3.0
44 stars 17 forks source link

Recheck repositories after aplied updates #11

Closed tobias-weiss closed 7 years ago

tobias-weiss commented 7 years ago

If would find it useful if as a last step of applied updates repositories are check again after applying updates as the number shown updates should go down to zero when update process is finished. So I have to manually to recheck in order to get rid of the notification.

franglais125 commented 7 years ago

Thanks for reporting this.

The indicator actually does check again after the upgrade command, the problem is not all methods report properly when they are done. Usually they report (return 0) right away, causing the indicator to check for updates again, before the upgrades where applied.

So... I am aware of the issue and I tried to fix it, the only way I found to make the notification go away properly it o choose a "custom" upgrade command, and to have this command be executed by xterm. I'll post a screenshot of this.

Edit: what upgrade method do you choose?

franglais125 commented 7 years ago

screenshot from 2017-05-13 12-35-43 screenshot from 2017-05-13 12-35-37

tobias-weiss commented 7 years ago

Thank you for swift reply. I am using custom method. Command to update packages was: pkexec apt uprade -y Terminal to use was: sudo gnome-terminal -x -bash -c

I think the double rights elevation was the source of the misbehavior. With the settings you posted the extension runs as desired.

Before the next update I will try to change to terminal to use again to gnome-terminal but without elevating rights.

tobias-weiss commented 7 years ago

Tried this with my second machine with custom settings: sudo apt uprade -y gnome-terminal -x -bash -c

After update with this setting the extension does not seem to get the proper return code, in consequence it does not reset the number of available updates.

In short: I have to stick to xterm then.

franglais125 commented 7 years ago

Exactly, gnome-terminal immediately returns "success" as soon as it opens up, instead of waiting for the process it's executing to finish. I think there is an upstream bug somewhere about this, but I couldn't find it...

franglais125 commented 7 years ago

@tobias-weiss I implemented a new way of applying the updates. It uses the /usr/bin/gpk-update-viewer binary. Fortunately it doesn't exit until it applies all the updates, so it will cleanly update the indicator!

If you can, please try it out and let me know how it goes. It depends on the gnome-packagekit package.

sudo apt install gnome-packagekit to use it!

franglais125 commented 7 years ago

This is fixed in a new branch I'll merge soon: https://github.com/franglais125/apt-update-indicator/tree/reorganization

franglais125 commented 7 years ago

This was merged and released! Pending review on extensions.gnome.org.

Thanks!