search

franglais125 / apt-update-indicator

Apt Update Indicator
https://extensions.gnome.org/extension/1139/apt-update-indicator/
GNU General Public License v3.0
44 stars 17 forks source link

Usage of object.actor is deprecated #25

Closed TheSpartaPT closed 4 years ago

TheSpartaPT commented 4 years ago

Your extension is spamming this issue title to the gnome-shell journal Check it like this: 

$ sudo journalctl /usr/bin/gnome-shell | grep -E 'apt-update-indicator|AptUpdateIndicator'

I fixed it by deleting the extension, cloning the repo, deleting all the references in your code to the property .actor everywhere and then installed it

so for example on indicator.js:99 this:

this.actor.add_child(this.box);

became this: 

this.add_child(this.box);

seems to have fixed it, idk if that's the best or the only solution to the problem, I won't PR it because I didn't bother to check if what I was doing was right so I might have created more issues in the process, although it seems to be working as intended.

TheSpartaPT commented 4 years ago

forgot to mention, I'm on gnome-shell v3.34.1

franglais125 commented 4 years ago

Indeed, I need to update the extension to support newer version of Gnome! Hopefully I can try this in the next few weeks/months. Patches welcome.

franglais125 commented 4 years ago

Fixed on v21. Uploaded to extensions.gnome.org. Cheers!