search

franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
278 stars 40 forks source link

Does not properly uninstall #105

Open catb0t opened 5 years ago

catb0t commented 5 years ago

The lines

https://github.com/franglais125/no-title-bar/blob/0fd20f31b5bd102fbfcbe2ad78c6e614ebb4b77f/decoration.js#L469-L477

cause @import url statements to deleted files to be leftover in ~./config/gtk-3.0/gtk.css when the extension is removed, as reported in #73.

73 was closed when the person decided just to remove the lines from gtk.css which works but I'm reporting that the extension doesn't remove the lines correctly, i.e.

https://github.com/franglais125/no-title-bar/blob/0fd20f31b5bd102fbfcbe2ad78c6e614ebb4b77f/decoration.js#L480-L482

does not work properly when called by _disable.

peter-kehl commented 3 years ago

Confirming this defect: After uninstalling the extension, when I start Firefox from a terminal, it reports:

(/usr/lib/firefox/firefox:4777): Gtk-WARNING **: 13:41:38.944: Theme parsing error: gtk.css:4:114: Failed to import: Error opening file /home/pkehl/.local/share/gnome-shell/extensions/no-title-bar@franglais125.gmail.com/stylesheet.css: No such file or directory (/usr/lib/firefox/firefox:4777): Gtk-WARNING **: 13:41:38.944: Theme parsing error: gtk.css:5:120: Failed to import: Error opening file /home/pkehl/.local/share/gnome-shell/extensions/no-title-bar@franglais125.gmail.com/stylesheet-tiled.css: No such file or directory Thank you for no-title-bar and for considering this report.

For anyone following the instruction above: the correct location of file to edit is ~/.config/gtk-3.0/gtk.css.