search

franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
278 stars 40 forks source link

Broken in GNOME 3.32.0 #114

Open aulospl opened 5 years ago

aulospl commented 5 years ago

The extension loads but no longer works on GNOME 3.32.0.

Wuestengecko commented 5 years ago

It loads, but only works partially. The buttons in the top bar are present and work (minimize and close), I can drag down from the panel to grab the window, but title bars are no longer hidden. Looking Glass says there hasn't been any error message, journalctl confirms.

Gnome Shell 1:3.32.0+15+gb7d79a5f0-1 NTB v9-7-g7e14934 Arch Linux

meridius commented 5 years ago

I get nothing in my LG and following in my journal:

bře 17 15:30:02 dixcall gnome-shell[2050]: JS ERROR: Could not load extension no-title-bar@franglais125.gmail.com~: Error: uuid "no-title-bar@franglais125.gmail.com" from metadata.json does not match directory name "no-title-bar@franglais125.gmail.com~"
                                            createExtensionObject@resource:///org/gnome/shell/misc/extensionUtils.js:196:15
                                            _loadExtension@resource:///org/gnome/shell/misc/extensionUtils.js:239:25
                                            scanExtensions/<@resource:///org/gnome/shell/misc/extensionUtils.js:250:13
                                            collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:25:17
                                            scanExtensions@resource:///org/gnome/shell/misc/extensionUtils.js:249:9
                                            _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:326:5
                                            enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:334:9
                                            _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:365:9
                                            init@resource:///org/gnome/shell/ui/extensionSystem.js:373:5
                                            _initializeUI@resource:///org/gnome/shell/ui/main.js:222:5
                                            start@resource:///org/gnome/shell/ui/main.js:124:5
                                            @<main>:1:31
satriani-vai commented 5 years ago

In my case the option "Show buttons for all windows" do not work and a title bar is still not hidden as well. image image

sonicdebris commented 5 years ago

Having the same issue here (with Antergos). I noticed that some apps, like Firefox, now have no title bar by default (the window's close/minimize/iconify controls are on the level of tabs). Same for the settings, and gnome apps (which I think were like this even before, on 3.30). Some other apps, like Atom or QT Creator, still have the title bar, which is not hidden.

skewty commented 5 years ago

Apparently the Unite extension figured it out for 3.32. Perhaps the same "fix" will work for this extension.

MateuszKubuszok commented 5 years ago

Well, kinda. For now I moved to Unity extension, but it has this issue https://github.com/hardpixel/unite-shell/issues/74 that apparently comes from its approach (they had it for a long time). I never had this issue with no-title-bar, so personally I would hope for a fix that works with multiple screens. I don't know if copy-pasting their solution would not fetch their issues.

jmcomets commented 5 years ago

I tried switching to Unite & noticed a pretty substantial increase in CPU usage. I'd be happier if this was fixed :grinning:

bryango commented 5 years ago

High CPU usage seems to be caused by the top icon component. After disabling that, CPU usage looks normal for me. However, unite messes up the top panel (e.g. hardpixel/unite-shell#100), and it has too many features that I don't want, so I'd rather use no-title-bar as well. :stuck_out_tongue_winking_eye:

Ludonope commented 5 years ago

I have tried to modify the extension to make it work. It kinda works but not really. The bar is removed for the focused window when the shell is reloaded and that's all, I don't know why.

I have replaced the cmd in decoration.js in the method _setHideTitleBar.

let prop
let value

if (useMotifHints) {
    const flag = '0x2, 0x0, %s, 0x0, 0x0';

    prop = '_MOTIF_WM_HINTS';
    value = hide
        ? flag.format(Meta.is_wayland_compositor() ? '0x2': '0x0')
        : flag.format('0x1');
} else {
    prop = '_GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED';
    value = hide ? '0x1' : '0x0';
}

let cmd = ['xprop', '-id', winXID, '-f', prop, '32c', '-set', prop, value];
bryango commented 5 years ago

High CPU usage seems to be caused by the top icon component. After disabling that, CPU usage looks normal for me. However, unite messes up the top panel (e.g. hardpixel/unite-shell#100), and it has too many features that I don't want, so I'd rather use no-title-bar as well.

After some experiments I find that the side effects of unite can be eliminated by simply commenting out its stylesheet.css. Now unite seems quite usable to me!

diabolicle commented 5 years ago

I've been using https://github.com/velitasali/GTKTitleBar/ on 3.32 without any issues.

uniquePWD commented 5 years ago

I've been using https://github.com/velitasali/GTKTitleBar/ on 3.32 without any issues.

Such a simple and beautiful implementation, thank you for the heads up.

weeman1337 commented 5 years ago

GTKTitleBar is fine so far, but one thing is really missing for me: Closing an application is painful. If have to minimize it and then click the X. I also appreciate the white and black list function of no title bar.

So +1 for getting this thing running in 3.32.

dkiyatkin commented 5 years ago

its working for terminal with this option settings set org.gnome.Terminal.Legacy.Settings headerbar false