search

franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
279 stars 40 forks source link

Multi-monitor support (placeholder) #14

Closed franglais125 closed 7 years ago

franglais125 commented 7 years ago

This is just an announcement to some people I found asking about this. I implemented a feature to deactivate "pixel-saver" on secondary monitors. I uploaded the fork here: https://extensions.gnome.org/extension/1267/no-title-bar/

@the0demiurge @NNois @Zbob750 @1029chris @arcresu @passcod @highvoltage @hackel @kmhofmann @shihrer @overjt @nxadm @cfviotti

passcod commented 7 years ago

Any reason why this isn't a Pull Request on the original?

kmhofmann commented 7 years ago

The original author was reluctant to merge in anything related to that feature, or didn't react anymore at all? See the discussion here: https://github.com/deadalnix/pixel-saver/pull/115

franglais125 commented 7 years ago

Exactly. I merged a couple of other PRs as well into this fork.

franglais125 commented 7 years ago

Tagging @guenhter

guenhter commented 7 years ago

@franglais125 do you plan to create a pull-request for your changes or do you develop this fork independently?

franglais125 commented 7 years ago

I created a PR for this feature months ago (see link above), but the reluctance of the maintainer to include any settings at all made me close that PR and simply fork it for good.

If you go to the PR, you can see I indeed tried to collaborate, as I hate having duplication of effort, and I maintain other extensions as well. But in the end, it was hurting users not having any settings at all.

guenhter commented 7 years ago

Ah, I see. You really put a lot of effort into this. Very sad do hear that your hard work isn't appreciated by the author...

shihrer commented 7 years ago

👍

Thanks for implementing this (and for bringing it to my attention). I'll have to check it out sometime.

franglais125 commented 7 years ago

@guenhter Well, I don't want to say that the original author didn't appreciate it, he might be very busy! If anything the lack of feedback was the frustrating part...

Anyway, I'm glad people find it helpful.

franglais125 commented 6 years ago

@NNois Give this extension a try, I've included the multi-monitor support.

NNois commented 6 years ago

@franglais125 just perfect ! congrats