franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
279 stars 40 forks source link

Takes some time to show the correct title after switching tabs in Firefox #17

Closed anupam207 closed 6 years ago

anupam207 commented 7 years ago

I usually observe this issue after using Firefox for quite some time. I have Replace App Menu name with Window name option on. So the tab title is shown on the top panel. But when I switch to another tab the title of the previous tab is shown for some time before correctly showing title of the current tab.

Distro: Ubuntu GNOME 17.04, shell version 3.24.2 I noticed the same issue with Pixel Saver too.

franglais125 commented 7 years ago

Thanks a lot for reporting this! I'll try to take a look as soon as possible.

Edit: I just quickly tried to reproduce this, but I can't on my system. Does it happen all the time, or in specific situations? For instance, after a long session is in use, multiple monitors, etc.

anupam207 commented 7 years ago

@franglais125 I don't use multiple monitors, only one laptop screen. And as I mentioned, it starts occurring after using Firefox for quite some time.

anupam207 commented 7 years ago

Here's a screenshot. It shows the title of the previously selected Wikipedia tab, instead of the current GitHub tab. tab-switch I noticed whenever the issue is present, if I right click on the current tab or inside the current page, it immediately starts showing the correct title.

franglais125 commented 7 years ago

Sorry for the late reply, as I mentioned somewhere else, I'm traveling at the moment. I'll try to look into it soon.

In any case, this sounds more like a problem within Firefox rather than the extension. I certainly don't mean to sound dismissive - I'll test this myself.

Let me know if you can get more information, and I'll let you know as soon as I understand better the cause of the issue.

Cheers!

franglais125 commented 6 years ago

I think this might have been fixed with the latest commit to master [8a1406a]. Would you mind testing the latest master branch?

anupam207 commented 6 years ago

@franglais125 Thanks a lot for your reply. Here's what I tried:

  1. I downloaded the master zip from GitHub.
  2. Disabled No Title Bar from GNOME Tweaks.
  3. Extracted the contents of the zip to ~/.local/share/gnome-shell/extensions/no-title-bar@franglais125.gmail.com/ replacing the old files.
  4. Enabled the extension again.

But the extension threw error immediately: n-t-b-error

franglais125 commented 6 years ago

Hmm, would you mind doing the following:

anupam207 commented 6 years ago

@franglais125 I forgot to mention I restarted GNOME shell after activating the extension (I'm in Xorg). I'll try again and look for the error(s).

franglais125 commented 6 years ago

Ugh, silly me... Just remembered, installing from the zip from github is not ok. The reason is some things need to be "compiled", like the schemas, translations, etc.

In Ubuntu:

git clone https://github.com/franglais125/no-title-bar
cd no-title-bar/
make install

And then reload. If you don't have all the utils: sudo apt install make git gettext

anupam207 commented 6 years ago

Thanks again @franglais125 . I just git cloned and built using make just as you suggested, and then logged out and logged in again. But unfortunately it's still throwing error.

I ran sudo journalctl /usr/bin/gnome-shell and found this line repeated a few times: Extension "no-title-bar@franglais125.gmail.com" had error: Error: second argument to Lang.bind() must be a

P.S. One more thing I forgot to mention, I have upgraded to Ubuntu 17.10, GNOME shell v3.26.1.

franglais125 commented 6 years ago

I just left home, so I don't have my laptop with me, but I'll check later.

Can you post the full error? Perhaps with a line number? You can use:

sudo journalctl /usr/bin/gnome-shell

To check for new errors as they happen.

anupam207 commented 6 years ago

Closing this. The issue seems to be solved in version 7/8.