No close button for half maximized windows

franglais125 / no-title-bar

Integrates maximized windows with the top panel

https://extensions.gnome.org/extension/1267/no-title-bar/

GNU General Public License v2.0

279 stars 40 forks source link

No close button for half maximized windows #22

Open jonnius opened 6 years ago

jonnius commented 6 years ago

When I maximize a Window to half of the screen (e.g. SUPER+LEFT) it will hide the title bar, but no close button appears. Works fine with fully maximized windows (SUPER+UP).

franglais125 commented 6 years ago

@jonnius Thanks a lot for taking the time of opening an issue!

n the last version of this extension, I made this functionality optional. Can you check the options to see if it works? If it doesn't, please let me know so I can investigate.

Here is a screenshot of the settings:

screenshot from 2017-09-16 16-08-16

jonnius commented 6 years ago

You are right. With this option it works.

As a user I would prefer the following configuration and behavior:

Have an option for removing title bar on snapped windows. If it is removed, close button behavior should be the same as with fully maximized windows.
Have an option to always use the close button on top panel, even if the title bar is not removed (restored windows). I got used to the close button next to the application menu, but cannot use it when window is not maximized...

hosseio commented 6 years ago

I can't see these options and I have just installed the extension. Is there another way to install it beyond gnome.extensions.org? Thanks in advance

jonnius commented 6 years ago

@y2josei yes, you can download it from github and replace the installed one at ~/.local/share/gnome-shell/extensions/no-title-bar@franglais125.gmail.com/

hosseio commented 6 years ago

For sure. Really cool @jonnius, thank you. I upvote for the behaviour described here: https://github.com/franglais125/no-title-bar/issues/22#issuecomment-330028484 That would make this extension glorious

mrprobot commented 6 years ago

I upvote jonnius suggestion too. A option to toggle the titlebar for snapped windows would be great.

franglais125 commented 6 years ago

Thanks everyone for the feedback. I can't dedicate as much time as before to this extension, so some details might fall through the cracks of my memory.

Regarding @jonnius suggestion, which seems to be popular here, can someone tell me if the current git master is ok with this view? If it isn't would you mind re-explaining it? Some things might have changed in the last two months, so I'm not sure anymore of how this issue evolved.

Thanks a lot!

jonnius commented 6 years ago

I have just tested the most recent version. On snapped windows it works fine now. Thanks for that! But there is still one issue and a related feature request:

If I click the close button it closes one of the maximized ones, not the one focused (if that one is not maximized). This is highly confusing. Please, always close the focused window, not just one the maximized ones that are not focused.
Have an option to show the close button if there is any window, not only if there is a maximized one.

Keep up the good work and thanks so far!

franglais125 commented 6 years ago

If I click the close button it closes one of the maximized ones, not the one focused (if that one is not maximized). This is highly confusing. Please, always close the focused window, not just one the maximized ones that are not focused.

This was confusing for me as well at first, when using the Pixel Saver extension. The idea is that the top bar is the actual title bar of the maximized window, while the non-maximized one already has accessible buttons.

I have to agree that this is not the most intuitive behavior, but I kept it like that as I guessed that's what people were used to. I don't personally use the button much, so I can change this.

Thanks @jonnius for your input. Anyone else cares to give an opinion on this matter?