search

franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
279 stars 40 forks source link

Doesn't work with GNOME Terminal in Wayland session #24

Closed anupam207 closed 6 years ago

anupam207 commented 6 years ago

Title bar doesn't go away if I maximize GNOME Terminal in Wayland session. I noticed this for Terminal, but I think it happens with all the windows running in Wayland. Windows running in XWayland, for example Firefox, seem to behave as expected.

Distro: Ubuntu GNOME 17.04, shell version 3.24.2

franglais125 commented 6 years ago

Hi, thanks for taking the time of opening an issue!

In this case, unfortunately there is nothing I can do. This extension only works on X and on XWayland windows. Since GNOME terminal runs natively on Wayland, I can't remove the title bar.

Note that this is not a problem with the extension, or something I can fix, it simply can't be done with an extension.

For more info you can look at this issue https://github.com/franglais125/no-title-bar/issues/19.

Sorry! And cheers!

anupam207 commented 6 years ago

No problem. Thanks for your quick reply. Strange to see Terminal not using client side decoration like other GNOME apps. Hope they'll fix it soon.

franglais125 commented 6 years ago

Indeed, I'd like that too!

Closing...

franglais125 commented 6 years ago

I got this working on Wayland with the latest version from git. Would you mind testing it?

anupam207 commented 6 years ago

@franglais125 I've moved back to Xorg as so many things were not working with Wayland :( I'll test the new version as soon as I start trying Wayland again. But can't promise it'll be very soon :(

morphheus commented 6 years ago

As of today, on a fresh gnome 3.26 install, gnome-terminal's borders do not get removed on Wayland. edit: I wasn't using the the git version :S. I can confirm that this extension works for gnome-terminal in Wayland. However, it requried a relogin for it to take effect.

franglais125 commented 6 years ago

@morphheus great to know that it works for you :). And yes, a relogin is necessary.