search

franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
279 stars 40 forks source link

Invert button order #28

Open hmlendea opened 6 years ago

hmlendea commented 6 years ago

Hello.

Can you add a toggle to invert the order of the buttons?

It feels really weird to have [ □ x ] when having them in the left hand part of the panel (after the AppMenu). When inverted they should be: [ x □ ]

franglais125 commented 6 years ago

Hi! Thanks for the suggestion, I'll try to tackle this when I have some time.

In the meantime, I don't really understand the logic.

  1. What do you mean by "when inverted"? And in what way does it feel weird?
  2. I know that this is perhaps not exactly what you are looking for, but you can play with the order by using: gsettings set org.gnome.desktop.wm.preferences button-layout ':close,maximize,minimize'. The order you use (and the :) sets the order and position of the buttons for the Shell, and for this extension.
hmlendea commented 6 years ago

I tried the gsetting. It changed the ones on title bars but not the ones from the extension. To be honest, I haven't restarted the system since. I will try it again today.

franglais125 commented 6 years ago

@hmlendea any luck?

hmlendea commented 6 years ago

Yes, sorry for not reporting earlier. Yes, it works :) However I have another issue as the position of the buttons gets reset after restarting the shell. It keeps putting itself at the left end of the bar, right in the corner, when in reality I configured it to stay at the right of the AppMenu.

Actually, anything I set there, except "Hidden", isn't working. Autohide doesn't work either. It's most probably the same problem as #12.

echonaut commented 6 years ago

FYI regarding this issue: if you're using this extension and you change the setting for buttons on left or right side, WHILE THE EXTENSION IS ENABLED, it'll reflect the previous setting. You have to disable and re-enable the extension to make it respect the change.

hmlendea commented 6 years ago

@echonaut I did. And the order of the buttons is fine. Now I have other problems, unfortunately :(

franglais125 commented 6 years ago

Hey guys, thanks for the feedback on this. I'll try to see what I can do about it when I get some time. As I have expressed elsewhere, patches are welcome if anyone is wiling to look into this.