search

franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
279 stars 40 forks source link

Doesn't affect gnome-terminal #34

Closed ghost closed 6 years ago

ghost commented 6 years ago

Have installed this extension, and it works for Firefox and Thunderbird, but doesn't seem to affect gnome-terminal 3.24.2 running on Ubuntu 17.10.

franglais125 commented 6 years ago

Hi! Thanks for reporting this. You are most likely using the Wayland session... Unfortunately, we can't remove the titlebars on Wayland. The reason Firefox and Thunderbird work is because they are not native Wayland clients, and work through XWayland.

If you feel like installing the latest code from git, I've added a css class that takes care of this problem for some apps in Wayland, but there is only so much we can do.

Can you confirm this? Are you on Wayland?

ghost commented 6 years ago

Yes, I've just upgraded to Ubuntu 17.10 which uses Wayland.

franglais125 commented 6 years ago

If you feel like it, you can test the code directly from git, which has a few more commits not yet released to extensions.gnome.org.

Some feedback on that would be great.

ghost commented 6 years ago

Would you have any instructions on how to do that for someone who only started using Gnome extensions a few hours ago?

franglais125 commented 6 years ago

Sure, here it is:

git clone https://github.com/franglais125/no-title-bar
cd no-title-bar
make install

Log out and log in again. You might need to install a few things:

sudo apt install make git gettext
ghost commented 6 years ago

Thank you, that works. Do you have any plans to include this feature in the official release?

franglais125 commented 6 years ago

Yes! The problem I have now is that I can't selectively apply the css classes, it's either all or nothing, so some options in the GUI are useless.

I want to see how to deal with this first.

szuliq commented 6 years ago

Now the Ubuntu 17.10 is out (Wayland + drop Unity) I believe this is a great time for "No Title Bar" to gain popularity. People want all the space they can get, especially on small screens.

Did you consider making a note regarding Wayland on the extension's page?

Great work, thanks for the extension.

franglais125 commented 6 years ago

@szuliq Thanks for the feedback! I now added a note concerning Wayland support.

A new version was uploaded and is awaiting review. I'll close this issue now.

Thanks everyone!