search

franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
279 stars 40 forks source link

Improved button vertical alignment #46

Closed davidwlewis closed 5 years ago

davidwlewis commented 6 years ago

The window buttons tend to hang a couple of pixels away from the top edge of the screen. Other themes might need adjusting, I just use default.

franglais125 commented 6 years ago

Thanks a lot for your contribution!

I'm having a hard time seeing the improvement (at least in my testing). Could you provide a screenshot of the "before/after" look?

In my testing, the default look is vertically centered. With the patch, everything is stuck to the top of the panel. This could, however, look different for you, hence why I'd like to see your case :)

Again, thanks for looking into this!

davidwlewis commented 6 years ago

The problem is that a row or two of pixels above the buttons aren't clickable. After the change, in my setup there is no discernible visual difference:

before2 after2

But the top 2 rows of pixels are clickable - so I can just mouse to the corner of the screen and not have to nudge down a little. For whatever reason just changing the css to make the buttons slightly taller wasn't enough, they still sat a pixel or two away from the edge.

If this breaks setups with taller top bars, perhaps it should be configurable, or I can see if I can find a way to make the clickable area of the button span the vertical space.

franglais125 commented 6 years ago

But the top 2 rows of pixels are clickable - so I can just mouse to the corner of the screen and not have to nudge down a little. For whatever reason just changing the css to make the buttons slightly taller wasn't enough, they still sat a pixel or two away from the edge.

Ah, I see! Thanks, I didn't think about the clickable area, I was more focusing on the aesthetics. I'll take another look soon. Cheers

bmarwell commented 6 years ago

:+1: looking forward to integration!

franglais125 commented 6 years ago

I've reworked this patch a bit, and added it to master. Would you mind testing it/providing feedback?

Essentially, I enlarged the icons to fill the bar, but some themes need to be adjusted... I didn't modify the Canta and Zukitwo ones.

franglais125 commented 5 years ago

I'll assume this has been completed. We can re-open if necessary. Cheers and thanks for your contribution!