franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
278 stars 40 forks source link

Titlebar-less Firefox doesn't get blacklisted #79

Closed ghost closed 5 years ago

ghost commented 6 years ago

I have an issue harmonizing Firefox with titlebar disabled (which thank goodness has been introduced on the latest version on Linux) and this extension. Both without any list, and by putting Firefox on the blacklist, I see buttons both on Firefox next to the tabs, and right above on the title-bar. I'd like the extension to not show the top bar buttons when Firefox is maximized as it already has them next to the tabs. The same issue arises with Firefox Developer edition (I blacklisted both and it works for none of 'em). The funniest part perhaps is that they get indeed blacklisted in some way, as, if I activate the titlebar, they don't lose it when maximized, but the minimize, window, close buttons still appear on the top bar as well as on the title bar.

Perhaps the bug is that blacklist, while not removing the titlebar from the blacklisted apps, doesn't prevent making the buttons on the top bar appear for them?

dboy591 commented 6 years ago

Same here. Looks like the blacklist still keeps the buttons in the top bar. That is the real issue.

franglais125 commented 5 years ago

This was addressed by PR https://github.com/franglais125/no-title-bar/pull/86. Thanks for reporting the issue!

ghost commented 5 years ago

I'm sorry to complain, but now it has the opposite effect: if I use a blacklist no app gets the titlebar removed at all... for example I have only Firefox in the blacklist, but Visual studio code doesn't have the titlebar removed...

Also, how does the release schedule on extensions.gnome.org work? I had to install this from source as the version there was still the old one. Which is quite annoying since I have to manually recompile from source upon newer updates.