search

franglais125 / no-title-bar

Integrates maximized windows with the top panel
https://extensions.gnome.org/extension/1267/no-title-bar/
GNU General Public License v2.0
278 stars 40 forks source link

Will break with gnome-shell 3.30 #93

Open eddy-geek opened 5 years ago

eddy-geek commented 5 years ago

Extension does not start on Fedora 29 Beta, gnome-shell 3.30 RC (3.29.91-1)

Current Behavior

Following errors are printed:

TypeError: global.screen is undefined
appMenu is null
TypeError: global.screen is undefined

Possible Solution

See https://github.com/home-sweet-gnome/dash-to-panel/issues/434 and fix https://github.com/micheleg/dash-to-dock/pull/770

Basically global.screen moved to global.display, while all the workspace related features have been moved to the WorkspaceManager and displays are managed by DisplayManager.

Also the built-in extensions update commit

Your Environment

eddy-geek commented 5 years ago

Actually the work for this has been done already. I can confirm git master works with 3.29.91.

What is missing is the update of the official gnome-shell store.

uniquePWD commented 5 years ago

Has this been uploaded to Gnome Extensions, there's apparently nothing waiting in the review queue for this.

aspidxt commented 5 years ago
uniquePWD commented 5 years ago

Hopefully @trustin can make a pull request with the changes he proposed in #97 so they can merged.

trustin commented 5 years ago

I release the diff I published in #97 under public domain as defined in https://creativecommons.org/publicdomain/zero/1.0/deed.en

Please feel free to take it and do whatever you wanna do, e.g. sending a new PR or merging it into your repository.

uniquePWD commented 5 years ago

Done. Thank you @trustin

uniquePWD commented 5 years ago

Does anyone know what @franglais125 is planning to do with this extension?