search

frangoteam / FUXA

Web-based Process Visualization (SCADA/HMI/Dashboard) software
https://frangoteam.org
MIT License
2.73k stars 804 forks source link

Fix alarm counter in header to display only active alarms #1229

Closed mauroalexandre closed 2 months ago

mauroalexandre commented 3 months ago

Currently, the alarm counter in the header sums all alarms regardless of their status, including those with the status AlarmStatusEnum.VOID, resulting in an incorrect number.

This pull request modifies the counter to display only the ACTIVE alarms. This behavior is standard in other tools, but we can improve it in the future to make this behavior configurable.

unocelli commented 3 months ago

Your modification only counts alarms that are in status ON, for me OFF and ACK status must also be counted, therefore all those in the alarms table, alarms are then removed from the table automatically according to the mode. Maybe the issue you are having is a different one and there are 'ghost' alarms left in the table (not removed for another issue).

LordNetro commented 3 months ago

It happens to me whenever I press the ACK all only, any thoughts? I think there is a problem with that button, it only happens when I click that. See image for example: image

MatthewReed303 commented 3 months ago

I can confirm I have issues with the alarm count also, if you ACK one alarm at a time it will be correct, if you ACK all it stuffs up the count. This has be a complaint from multiple customers. The alarm count indicator should only display active alarms and that's it

unocelli commented 3 months ago

Thanks for the report, the issue should be fixed

unocelli commented 3 months ago

Hi, can you please confirm that the problem has been solved

mauroalexandre commented 3 months ago

Hi, can you please confirm that the problem has been solved

Solved, thanks. In sometimes status = '', your codeguard fixed this.

Thanks alot.