search

franiglesias / versiontag

Bash command to automate tag semantic versioning
MIT License
46 stars 13 forks source link

Fix CR problems in tests and use printf instead echo #11

Closed franiglesias closed 5 years ago

franiglesias commented 5 years ago

With this PR we fix some problems with the CR in test files that was causing problems to compare expected and actual output.

Also switched to use printf instead of echo to better compatibility.

Note that currently not all tests are passing expecting to better design the output of the command.

pkristian commented 5 years ago

So now are tests white-space sensitive? right?

What problems with compability you ran into?

franiglesias commented 5 years ago

I was having problems running tests in my current installation (Mac OS X):

GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin17)
Copyright (C) 2007 Free Software Foundation, Inc.

I will need some time to test under other conditions to confirm fixes.

pkristian commented 5 years ago

general notes:

  1. LF... i like that, my bad it was not there
  2. switched to spaces (over tabs)? okay
  3. please fix major test, untill then i cannot aprove whole thing 👼
pkristian commented 5 years ago

and oh yes, i am runing it on git-bash.exe which is based on MINGW64. FYI :)

franiglesias commented 5 years ago

major test failing is related to the .semver thing (which was no present when you wrote the tests. Now that I make them run, I think I will better suited to improve things), so I'm going to fix it first and perform some cosmetic changes in the outputs.

I prefer spaces over tabs, yes. :-)

pkristian commented 5 years ago

yep, i al looking forward to you fixing tests.. please also comment my code comments

franiglesias commented 5 years ago

Sorry, I forgot to click the send button 😂

pkristian commented 5 years ago

good, when you will send updated commit, i will review it and hopefully all will be nice :)

franiglesias commented 5 years ago

I guess I need some sleep 💤