search

frank-w / BPI-Router-Linux

Linux kernel 4.14+ for BPI-R2, 5.4+ for R64, 6.1+ for R2Pro and R3
Other
136 stars 47 forks source link

Pad ethernet packets to 40 bytes, which fixes PPPoE #128

Closed MagicRB closed 3 months ago

MagicRB commented 3 months ago

Without this patch, PPPoE fails to establish a connection, the following appears on the side of the router:

00:14:05.757066 PPPoE  [ses 0x1] LCP, Conf-Request (0x01), id 3, length 16
00:14:05.785905 PPPoE  [ses 0x1] LCP, Conf-Request (0x01), id 1, length 16
00:14:05.786068 PPPoE  [ses 0x1] LCP, Conf-Ack (0x02), id 1, length 16

but on the other side only the following is visible

22:06:56.448149 PPPoE  [ses 0x1] LCP, Conf-Request (0x01), id 1, length 16

these packets are too small and so the hardware fails to compute the CRC, I think. The patches themselves give more detail.

MagicRB commented 3 months ago

Confirmed to work with PPPoE as required by the Dutch ISP KPN, achieving speeds of 800 Mbps symmetric, which is around where KPN caps out normally.

frank-w commented 3 months ago

maybe you want to upstream these changes? do not forget to add your signed-off-by

MagicRB commented 3 months ago

I pulled it from mediateks tree:

So its up to them to upstream