search

frank-y-liu / SPRNT

a river dynamics simulator
Eclipse Public License 1.0
30 stars 20 forks source link

Fread Method implementation and example cases updated (including golden) #7

Closed yuchanway closed 4 years ago

yuchanway commented 4 years ago

Fread method implementation and golden cases updated.

yuchanway commented 4 years ago

Frank, I've cleaned the unnecessary files in .vscode/ and Thirdparty/ . It seems that I might have skipped a step of cleaning so that there are files left in there. I think it is ready to be pull. Please let me know if there is anything I need to change.

frank-y-liu commented 4 years ago

@yuchanway Looks good. I assume all .png and .pptx files are needed for the revised user guide? I noticed that there are a few files which should not be included in the pull request.

  1. A few .DS_Store files specifically related to mac OS;
  2. A few latex auto generated .aux, .log and .synctex.gz files;
  3. There is a text.txt file which I am not sure if it's needed.

In addition, there are a few files in the doc directory using a non-western font. I would rename them using a western font to avoid causing problems on old local computers.

Please fix these files and rebase the code (e.g., use git rebaset -i). And I will merge the code.