Remember position of splitter

[GoogleCodeExporter]

Thanks for gnome-mplayer. Great app. I have a feature request for 0.9.8,
I'd like to be able to move the media info out of the way and just have the
playlist with the controls below it as in earlier versions. Is it possible
to either make the media info display optional, or just have the player
remember where the playlist/media info splitter was when it was last closed?

Thanks,
Matt

Original issue reported on code.google.com by arsiso...@gmail.com on 9 Oct 2009 at 5:02

[GoogleCodeExporter]

Sry, seem to have filed it as a defect, but it's obviously an enhancement --M

Original comment by arsiso...@gmail.com on 9 Oct 2009 at 5:04

[GoogleCodeExporter]

I've spent hours on the splitter position. Just haven't found the right way to 
do it
yet, and it is not fun to debug it. Have you tried using gnome-mplayer with the
playlist on the bottom? Choose vertical layout in the preferences.

Original comment by kdeko...@gmail.com on 9 Oct 2009 at 6:28

• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Can you try SVN, spent another couple of hours battling with this and finally 
got it
I think

Original comment by kdeko...@gmail.com on 13 Oct 2009 at 5:56

• Changed state: Started

[GoogleCodeExporter]

Many thanks :). I'll give it a try when I get home.

Original comment by arsiso...@gmail.com on 14 Oct 2009 at 11:09

[GoogleCodeExporter]

Hi Kevin,

I gave it a go and had mixed results. It seemed to work maybe the first two 
times I
opened it but slowly started inching towards the right on subsequent opens. By
roughly the 10th open it had taken up it's usual position with about 200px 
breathing
room for the playlist. I wonder if the width of the window manager borders is 
coming
into the calculations somewhere? Mine are 1px wide.

I'm a C# developer with no Linux experience whatsoever but I can try and give 
you
some help if you like. In theory I know my way around C.

--Matt

Original comment by arsiso...@gmail.com on 14 Oct 2009 at 7:57

[GoogleCodeExporter]

Matt, can you give SVN another try, I made a couple of patches that seem to 
improve
things.

Original comment by kdeko...@gmail.com on 15 Oct 2009 at 8:10

[GoogleCodeExporter]

It does improve things a bit but after say the 20th time the application is 
opened
the splitter has drifted over to the right again. I did a 'make clean' after an 
'svn
update' and moved the old binary out of the way to make sure I was using the 
latest one.

I've spotted something else in the process. With the playlist visible and the 
app in
vertical mode with a small (<100px) top panel: after dragging an mp3 onto the
playlist the width of the application window resizes to the height of the top 
panel
before playing.

Wish I had some better news for you. I know that resize code can be a 'pane' 
;). I'm
having a look at the code at the moment, if I can be of any help I'll let you 
know.

Original comment by arsiso...@gmail.com on 16 Oct 2009 at 6:46

[GoogleCodeExporter]

Hi Kevin,

I've spent quite a few hours on this. I have come up with a solution but it's a 
bit
ugly. I've attached to the playlist resize event to set the correct splitter 
position
on startup, then detached after the third resize (which is the number of times 
the
event is fired before the playlist size is initialised). Hope it's some help 
anyway,
in its favour it works.

--Matt

Original comment by arsiso...@gmail.com on 17 Oct 2009 at 9:40

Attachments:

• gui.c.diff
• common.h.diff
• gui.c
• common.h

[GoogleCodeExporter]

Matt,

I'm a little concerned about this line

>     gtk_paned_pack1(GTK_PANED(pane), vbox, FALSE, TRUE);

I have not tried the patch yet, but when I played around with this value before 
it
did some weird things, but maybe the other part of the patch works around it. 
Did you
test this patch with both video and audio files?

Original comment by kdeko...@gmail.com on 17 Oct 2009 at 2:13

[GoogleCodeExporter]

Yes you're right. I didn't think to try out video and the results aren't good. 
For
audio with the layout as it is, it seems to make the most sense (i.e. resizing 
the
window gives you a bigger playlist). For video I'd imagine the user would want 
more
video rather than more playlist when they resized. I understand why you had the 
right
pane fixed now.

For whatever reason I didn't imagine you'd consider patching the code with 
that. I'm
a fresh Windows convert and a bit like a rabbit in headlights at the moment 
between
the technology and the culture. I'll do a bit more on it and test it properly 
then.

Original comment by arsiso...@gmail.com on 17 Oct 2009 at 2:48

[GoogleCodeExporter]

Matt,

However, the vertical layout was an issue. And I worked on that a little right 
now
and committed something to SVN. I think SVN works a little better now in both 
modes
and now when the playlist is visible the player window does not resize at all, 
which
I believe is the more correct behavior

Kevin

Original comment by kdeko...@gmail.com on 17 Oct 2009 at 3:05

[GoogleCodeExporter]

Okay, I'll take a look, probably tomorrow now. I'm a bit worried about a fixed 
window
though, I'll sometimes resize the playlist if, say, I've got a double album on 
there
and want to see it all on screen. Of course I appreciate my needs might not be
representative of the world at large. I use mythtv for videos so I'm just 
looking for
a solid media player with good sound, preferably jack output so I can put FX 
inline,
and no disk-churning media libraries.

Original comment by arsiso...@gmail.com on 17 Oct 2009 at 3:25

[GoogleCodeExporter]

Any comment on this?

Original comment by kdeko...@gmail.com on 26 Oct 2009 at 1:10

[GoogleCodeExporter]

Hello Kevin,

First of all - sorry for my English.

I've tested gnome-mplayer SVN revision 1590 and found several problems:

1. 1. When I use gnome-mplayer in "playlist mode" and split pane is moved 
to the edge of left corner, any song change is bring to upheaval of split pane. 
2. GNOME-Mplayer does not remember position of split pane between sessions.
3. GNOME-Mplayer does not remember the size of the columns in playlist between 
sessions.
4. Also gnome-mplayer does not remember states for next items: 
   * Audio meter
   * Shuffle playlist
   * Loop playlist
   * Details

Original comment by dkorya...@gmail.com on 21 Nov 2009 at 12:34

[GoogleCodeExporter]

1. you are correct on that, odd that it doesn't do it if just a little of the 
song
title is visible

2. Probably related to 1

3 & 4 are not in the code, so that is why they don't do what you expect.

Original comment by kdeko...@gmail.com on 21 Nov 2009 at 2:48

[GoogleCodeExporter]

Kevin, 

Thanks for you answer. 
Do you have a plans to implement #3 and #4 features? 
It would be very nice. 

Original comment by dkorya...@gmail.com on 22 Nov 2009 at 10:46

[GoogleCodeExporter]

Noe sure yet, you are the first to ask for it.

Original comment by kdeko...@gmail.com on 22 Nov 2009 at 1:51

[GoogleCodeExporter]

Can you try r1594 or later and see if that works any better.

Original comment by kdeko...@gmail.com on 22 Nov 2009 at 3:41

[GoogleCodeExporter]

Hello Kevin,

I've tested GNOME-MPlayer SVN revision 1594 and found no problems with #1 and 
#2. 

Original comment by dkorya...@gmail.com on 24 Nov 2009 at 2:03

[GoogleCodeExporter]

Ok, I'm going to close this issue, and if you want to open a request for 3 & 4 
please
do that in a new issue, since we don't want to hijack this issue.

Original comment by kdeko...@gmail.com on 4 Dec 2009 at 3:37

• Changed state: Fixed