frankaemika / franka_ros

ROS integration for Franka research robots
https://frankaemika.github.io
Apache License 2.0
361 stars 311 forks source link

connected_to option in panda_gazebo.xacro #168

Closed LucasJoseph closed 2 years ago

LucasJoseph commented 3 years ago

It would be nice to have the connected_to argument in the panda_gazebo.xacro, similarly to panda_arm.xacro.

gollth commented 3 years ago

Sure, we can do that. May I ask how do you use this arg? Do you include the panda_arm.xacro in another more complex URDF?

LucasJoseph commented 2 years ago

Yeah, my robots are fixed on a table at different height and I include several panda_arm.xacro in my URDF.

gollth commented 2 years ago

Alternatively you can also connect the robot in the Xacro where you instantiate the panda_arm.xacro macro, right? Something like:

<robot xmlns:xacro="http://www.ros.org/wiki/xacro" name="myrobot">
  <xacro:include filename="$(find franka_description)/robots/panda_gazebo.xacro" />

  <xacro:panda_arm arm_id="panda" />

  <link name="YOUR_TABLE_LINK" />

  <joint name="table_joint" type="fixed">
    <origin xyz="0 0 TABLE_HEIGHT" rpy="0 0 0" />
    <parent link="YOUR_TABLE_LINK" />
    <child  link="panda_link0" />
  </joint>

<robot>

Would that also work for you?

LucasJoseph commented 2 years ago

Well, I could and that's what I did for now, but since the option is available in the panda_arm.xacro I wanted to be able to use it also with panda_gazebo.xacro

gollth commented 2 years ago

Make sense to have the same interface in both files. Added in bd2bfd8. Thanks for the input