search

frankaemika / franka_ros

ROS integration for Franka research robots
https://frankaemika.github.io
Apache License 2.0
356 stars 308 forks source link

chore: remove cmake minium version deprecation warning #354

Open rickstaa opened 1 year ago

rickstaa commented 1 year ago

Not sure if this is desirable given back-compatibility, but this pull request ensures that the cmake minimum version < 3.5 deprecation warning is no longer thrown:

Warnings   << catkin_tools_prebuild:cmake /home/ricks/development/work/franka_ros_ws/logs/catkin_tools_prebuild/build.cmake.000.log                                                                        
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):                                                                                                                                    
  Compatibility with CMake < 3.5 will be removed from a future version of                                                                                                                                  
  CMake.                                                                                                                                                                                                   

  Update the VERSION argument <min> value or use a ...<max> suffix to tell                                                                                                                                 
  CMake that the project does not need compatibility with older versions.
rickstaa commented 1 year ago

We can also update to version 3.10 since this is what is suggested by the migration guide.

rickstaa commented 1 year ago

@Maverobot, @marcbone I just fixed the latest CI errors, and I think we are now suitable for a merge 👍🏻.

Maverobot commented 1 year ago

@rickstaa Thank you for your report and the fix. We will take a loot at this PR.

rickstaa commented 1 year ago

I rebased this PR onto the develop branch and added a CHANGELOG entry.