In commit f2f82b2e4c3279d7196d1836049d649bd4252fb3, a robot namespace warning was introduced in the FrankaHWSim package. This warning was added to address a specific issue at the time (see https://github.com/frankaemika/franka_ros/pull/187#issuecomment-963242982). However, with the recent merge of PR #196, the conditions that necessitated this warning are no longer applicable.
To enhance the user experience and ensure clarity in error messages, I propose the following changes:
Remove Redundant Robot Namespace Warning: The warning introduced in f2f82b2e4c3279d7196d1836049d649bd4252fb3 is no longer needed since this warning only would be printed if the URDF is found. The URDF will only be found when the user specifies the correct robot namespace.
Change arm_id default value: In the original code, the robot_namespace was used as the default value for the arm_id attribute. This could trigger cryptic hardware transmission warnings if users forget to set the arm_id parameter on the robot_namespace. This can be solved by replacing the default robot_namespace with the model name as the default value for the arm_id attribute.
Introduce a warning mechanism that notifies users when they fail to load the arm_id parameter within the model parameter namespace. This will help users identify and resolve namespace-related issues more effectively.
Please let me know if you have any questions about my pull request.
In commit f2f82b2e4c3279d7196d1836049d649bd4252fb3, a robot namespace warning was introduced in the FrankaHWSim package. This warning was added to address a specific issue at the time (see https://github.com/frankaemika/franka_ros/pull/187#issuecomment-963242982). However, with the recent merge of PR #196, the conditions that necessitated this warning are no longer applicable.
To enhance the user experience and ensure clarity in error messages, I propose the following changes:
Change arm_id default value: In the original code, the
robot_namespacewas used as the default value for thearm_idattribute. This could trigger cryptic hardware transmission warnings if users forget to set thearm_idparameter on therobot_namespace. This can be solved by replacing the defaultrobot_namespacewith the model name as the default value for thearm_idattribute.Introduce a warning mechanism that notifies users when they fail to load the arm_id parameter within the model parameter namespace. This will help users identify and resolve namespace-related issues more effectively.
Please let me know if you have any questions about my pull request.