search

frankban / quicktest

Quick helpers for testing Go applications
MIT License
529 stars 27 forks source link

Return a more descriptive error message when Not is used with IsNil #126

Closed frankban closed 2 years ago

frankban commented 2 years ago

Fixes https://github.com/frankban/quicktest/issues/125

frankban commented 2 years ago

Thanks for the review! I agree that there is room for improving the negative messages for some other checkers. It would be nice to still have a good and sensible generic negative message as it is beneficial for all checker implementations that are not part of quicktest.

mvdan commented 2 years ago

Oh, for sure :)

frankban commented 2 years ago

Thanks for the reviews, filed https://github.com/frankban/quicktest/issues/129 for following up with other checkers.