frankcollins3 / fill_container

codecamp team project updated with new icon screen menu + puppeteer icon search, GraphQL, redux, relational psql !mongo, and accuweatherAPI
1 stars 0 forks source link

DESIGN FLAW lopsided after adding magnifying glass [4:22pm] #126

Closed frankcollins3 closed 1 year ago

frankcollins3 commented 1 year ago

original..wrestling with CSS and space-between and CENTER

    const renderPasswordInput = () => {
        return (
        <>
        <div style={{ display: 'flex', justifyContent: 'center', flexDirection: 'column', alignItems: 'center'}}>
        {/* <div className="column"> */}
<input id="password" type={INPUT_DBL_CLICK ? "text" : "password"} onFocus={inputfocus} value={PASSWORD_INPUT} onMouseEnter={ghosttext} onChange={(event) => { passwordinputhandler(event); }}/>
        <img onClick={inputDblClick} style={{ display: passwordShow ? "" : "none",  height: '25px', width: '25px', }} src="/water_img/statistics.png"/>
        </div> 
    </>
        )
    }

proposed approach:

    const renderPasswordInput = () => {
        return (
          <div style={{ display: 'flex', justifyContent: 'center', alignItems: 'center' }}>
            <input
              id="password"
              type={INPUT_DBL_CLICK ? "text" : "password"}
              onFocus={inputfocus}
              value={PASSWORD_INPUT}
              onMouseEnter={ghosttext}
              onChange={(event) => { passwordinputhandler(event); }}
              style={{ marginLeft: '40px' }} // Adjust the margin as needed
            />
            <div style={{ position: 'relative' }}>
              <img
                onClick={inputDblClick}
                style={{ display: passwordShow ? "" : "none", height: '25px', width: '25px' }}
                src="/water_img/statistics.png"
              />
            </div>
          </div>
        );
      };

problem with adding some margin: it must be taken off when the magnifying glass isn't there.

Screen Shot 2023-06-05 at 4 23 06 PM

😂 bookmark synergy: planting eyes into the screen to adjust for very specific 'px' and doing so for a magnifying_glass.png

frankcollins3 commented 1 year ago

why not just leave the password checker at the bottom and have the magnifying glass appear right underneath it ? [7:05pm]

frankcollins3 commented 1 year ago

👍 column [9:19pm]