search

frankcrawford / it87

226 stars 46 forks source link

`make dkms` creates directory suffixed with the current time rather than the commit time #23

Closed jaythegreatman closed 5 months ago

jaythegreatman commented 5 months ago

https://github.com/frankcrawford/it87/blob/043eae2cad7ee26f05a38b5602dce3c207bf974a/Makefile#L32 Because the dollar sign is not escaped by double it, make is treat the $(git show -s --format=%ci HEAD) part as a variable rather than pass it to shell.

frankcrawford commented 5 months ago

Thanks, I'll look at it.

frankcrawford commented 5 months ago

I've update the Makefile to correctly look up the commit time and pushed the commit.

frankcrawford commented 5 months ago

Closed.