Labels - Githubissues

frankframework / frank-doc

Frank!Doc

https://frankdoc.frankframework.org

Apache License 2.0

4 stars 5 forks source link

Labels #133

Closed mhdirkse closed 1 year ago

mhdirkse commented 1 year ago

This pull request is not done yet. I still have to do the following:

[x] Support label annotations that have an enum as value type.
[x] Test on the level of the wrapper API.
[x] Test a label annotation with a value field having a default value.
[x] Do we need label values of type String[] ?
[x] Document the new behavior in FRANKDOC.md and README.md

mhdirkse commented 1 year ago

I investigated why the build GitHub test failed. The F!F code cannot be processed by the frank-doc in this PR because a NullPointerException occurs in FrankElement.java line 226. That line tries to get the value of a label. I think the F!F has a label with its default value somewhere and that this does not work yet.

mhdirkse commented 1 year ago

We want to finish this quickly. For this reason we do not implement enum values and String[] values for labels. I will check the marks in the above comment.

mhdirkse commented 1 year ago

Linked to iaf PR https://github.com/ibissource/iaf/pull/3844

mhdirkse commented 1 year ago

@nielsm5, ik heb je commit voorstel voor de POMs geaccepteerd. Het was nog niet volledig, want er stond nog een onnodige versie in de front end. Die heb ik weggehaald. Ik heb de build uitgeprobeerd en ik kreeg de goede versies in de artifact namen. Ik denk dat het zo goed is; geen reden om nog iets met <dependencyManagement> te doen in de front-end. Ben je het daar mee eens?