frankframework / frank-doc

Frank!Doc
https://frankdoc.frankframework.org
Apache License 2.0
4 stars 5 forks source link

Flatten pom to update versions #180

Closed nielsm5 closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.09%. Comparing base (52b0531) to head (465c517).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #180 +/- ## ========================================= Coverage 84.09% 84.09% Complexity 1388 1388 ========================================= Files 79 79 Lines 4446 4446 Branches 526 526 ========================================= Hits 3739 3739 Misses 571 571 Partials 136 136 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mhdirkse commented 3 months ago

Wat is de bedoeling van deze PR?

jkosternl commented 3 months ago

Wat is de bedoeling van deze PR?

@mhdirkse, Hij fixt issues met lokaal een mvn install draaien en die vervolgens gelijk lokaal gebruiken. Ik kreeg:

Failed to read artifact descriptor for org.frankframework:frank-doc-doclet:jar:3.1-SNAPSHOT: 
The following artifacts could not be resolved: org.frankframework:frank-doc-parent:pom:${revision} (absent)

Dus dat zou het moeten oplossen.

mhdirkse commented 3 months ago

Ik zie alleen wijzigingen in de pom.xml en in .gitignore. De output van het doclet zou dus niet moeten veranderen. Ik zal het mergen.