frankframework / frank-doc

Frank!Doc
https://frankdoc.frankframework.org
Apache License 2.0
4 stars 5 forks source link

Opportunity for code cleanup: Remove deprecated methods registerChild #25

Open mhdirkse opened 3 years ago

mhdirkse commented 3 years ago

Describe the issue The Frank!Doc is quite complicated. One of the reasons has to do with method registerChild. This method has multiple overloads, causing multiple ElementRole objects sharing the same element role. This situation requires complicated logic in the Frank!Doc. Method registerChild is deprecated however. If we remove the registerChild methods, we may be able to remove much logic from the Frank!Doc. Doing so will make future development more easy.

Reporter Martijn Dirkse

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots If applicable, add screenshots to help explain your problem.

Configuration

Please provide the configuration of the Pipe or Receiver with the problem.

Input

Please provide an example of the input message. 
Alternatively, provide a Ladybug report.

Environment

Please go to the console of your Frank, click on 'Information' and copy-paste the results here. 

Additional Environment

Additional Context Add any other context about the problem here. (f.e. ladybug report / test adapter with larva test)

jacodg commented 3 years ago

We will do this later. Focus is now on releasing the xsd

mhdirkse commented 7 months ago

I checked whether we still have elements "Child" in the compatibility XSD. They are still there, so this issue cannot be picked up yet.