search

frankframework / frank-flow

Graphical flow editor for Frank configurations
https://frankframework.org
Apache License 2.0
29 stars 9 forks source link

frank-flow.context-path=/ gives: The page isn’t redirecting properly #1319

Closed jacodg closed 4 months ago

jacodg commented 5 months ago

Describe the bug Frank!Runner has always been using frank-flow.context-path=/ but with 2.27.1-20240501.205713 this gives in te browser:

The page isn’t redirecting properly

And in Tomcat logging:

2024-05-30 18:27:49.963 WARN 32560 --- [p-nio-80-exec-2] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:49.976 WARN 32560 --- [p-nio-80-exec-3] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:49.983 WARN 32560 --- [p-nio-80-exec-4] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:49.987 WARN 32560 --- [p-nio-80-exec-5] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:49.991 WARN 32560 --- [p-nio-80-exec-6] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:49.996 WARN 32560 --- [p-nio-80-exec-7] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.000 WARN 32560 --- [p-nio-80-exec-8] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.004 WARN 32560 --- [p-nio-80-exec-9] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.008 WARN 32560 --- [-nio-80-exec-10] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.012 WARN 32560 --- [p-nio-80-exec-1] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.016 WARN 32560 --- [p-nio-80-exec-2] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.019 WARN 32560 --- [p-nio-80-exec-3] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.025 WARN 32560 --- [p-nio-80-exec-4] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.028 WARN 32560 --- [p-nio-80-exec-5] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.032 WARN 32560 --- [p-nio-80-exec-6] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.035 WARN 32560 --- [p-nio-80-exec-7] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.040 WARN 32560 --- [p-nio-80-exec-8] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.042 WARN 32560 --- [p-nio-80-exec-9] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.047 WARN 32560 --- [-nio-80-exec-10] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.050 WARN 32560 --- [p-nio-80-exec-1] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//] 2024-05-30 18:27:50.054 WARN 32560 --- [p-nio-80-exec-2] o.ibissource.frankflow.FrontendServlet : no path found, redirecting to [//]

When I remove frank-flow.context-path the Frank!Flow will run on:

https://localhost/frank-flow/frank-flow/

jacodg commented 4 months ago

With 3.0.0-20240612.114716 this doesn't happen anymore

philipsens commented 4 months ago

With 3.0.0-20240612.114716 this doesn't happen anymore

The property was actually removed, I thought that it was stupid. It is always / and if it is used as webapp than all endpoints are appended to the directory name of the webapp, like it should.

jacodg commented 4 months ago

For now I cannot remove it from the Frank!Runner as it also supports older F!F versions but I added a comment so it will be clear in the future that it can be removed:

https://github.com/wearefrank/frank-runner/blob/1df5682cb7af05738618a7e630f329f75112d540/build.xml#L66