frankframework / frank-flow

Graphical flow editor for Frank configurations
https://frankframework.org
Apache License 2.0
30 stars 8 forks source link

After some editing, you cannot see flowcharts anymore #1331

Open mhdirkse opened 2 months ago

mhdirkse commented 2 months ago

Describe the bug I downloaded project https://github.com/jjansenvr/frank-development-docker and added frank-flow.war to it as described in the README.md. I started it with docker-compose up. When I browsed to http://localhost:8080/frank-flow, I saw a flow-chart. There were two files with Frank configuration XML: Configuration.xml and Configuration_weather.xml. I updated Configuration.xml to add an extra include for file Configuration_martijn.xml and added that file. The file was automatically filled with a Hello World example. But at this point, I could not see any flowcharts anymore. When I selected the mode to see flowcharts, the canvas went empty.

Reporter Martijn Dirkse

Category Use the following Tags to categorize your bug report

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here. (f.e. ladybug report, console error or test adapter with larva test)

mhdirkse commented 2 months ago

I got back my flowcharts as follows. I edited Configuration_martijn.xml outside the Frank!Flow in VSCode. It contained <Configuration name="${displayName}">. I changed it to just <Configuration> and saved it. In the Frank!Flow I saw the old code. I refreshed my browser. Then I saw a flowchart of file Configuration_martijn.xml.

philipsens commented 2 months ago

Sounds like this issue: https://github.com/frankframework/frank-flow/issues/1330