frankframework / frankframework

The Frank!Framework is an easy-to-use, stateless integration framework which allows (transactional) messages to be modified and exchanged between different systems.
https://frankframework.org
Apache License 2.0
130 stars 78 forks source link

Duplicate ignore options in Larva unit test tool #785

Closed Laurens-makel closed 7 months ago

Laurens-makel commented 4 years ago

Describe the bug Whilst writing a document which should describe all possible ignore options that can be used to write test scenarios I found out that there is a duplicate ignore option. It's regarding the "replaceKey" and "replaceEverywhereKey", they are just named a bit different but the execution is exactly the same:

image

Reporter Laurens, me.

Category

To Reproduce None, see image.

Expected behavior Not sure what I'd expect, this probably has to do something with backwards compatibility but having duplicate ignore options is a bit odd and confusing.

Screenshots See above

Environment:

Additional context Add any other context about the problem here. (f.e. ladybug report / test adapter with larva test)

jacodg commented 3 years ago

replaceEverywhereKey needs to be deprecated and a warning/message should be given how to fix it, something like replaceKey.global1.key1 as we can now use global identifiers