frankhale / electron-with-express

A simple app that demonstrates spawning an Express app from Electron
MIT License
643 stars 147 forks source link

Added a simple guard that prevents an exception being thrown on application exit #53

Closed minimallyexceptional closed 8 months ago

minimallyexceptional commented 8 months ago

Locally I kept getting the same exception over and over when closing the program.

It turns out that the server log entry was still firing slightly after the app had quit, leaving webContents undefined.

Just needed a simple guard return out once the app has been exited.

frankhale commented 8 months ago

Great catch! Thank you so much for fixing this.

minimallyexceptional commented 8 months ago

No problem! Keep up the good work, your roguelikes look awesome!